Conversation
…as a conflict The export, import and confirmation dialogs had a maximum width but no side margin, so below about 670px wide the panel touched both edges of the window with no gap. Added the same px-4 the other two dialogs already use. Separately, the import conflict check compared imported and current rules as JSON text. An export writes a rule's fields in a different order than the app builds them in - alphabetical, from serde_json::Value - so any context with auto-switch rules was reported as conflicting with itself on every import. Added sameRules(), which compares rules by what they do: field order and a missing matchCase/useRegex (same as false) no longer count as a difference; the order of the rules themselves still does. 5 new unit tests for sameRules. Frontend: 224 tests, svelte-check clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…as a conflict
The export, import and confirmation dialogs had a maximum width but no side margin, so below about 670px wide the panel touched both edges of the window with no gap. Added the same px-4 the other two dialogs already use.
Separately, the import conflict check compared imported and current rules as JSON text. An export writes a rule's fields in a different order than the app builds them in - alphabetical, from serde_json::Value - so any context with auto-switch rules was reported as conflicting with itself on every import. Added sameRules(), which compares rules by what they do: field order and a missing matchCase/useRegex (same as false) no longer count as a difference; the order of the rules themselves still does.
5 new unit tests for sameRules. Frontend: 224 tests, svelte-check clean.