Skip to content

ci: fix bash array quoting + shellcheck annotations #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janishorsts merged 3 commits into from
Jun 16, 2026
Merged

ci: fix bash array quoting + shellcheck annotations #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1af56e
ci: fix bash array quoting + shellcheck annotations
gilescope Jun 15, 2026
78a16b2
ci: quote -run testname via set --; stop re-spelling earthly token in…
gilescope Jun 15, 2026
38f811e
Merge branch 'main' into giles-ci-shell-fixes
janishorsts Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/reusable-misc-tests-1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@ jobs:
run: |-
${{inputs.SUDO}} ${{inputs.BINARY}} stop earthly-buildkitd || true && \
for i in 1 2 3 4; do
${{inputs.SUDO}} ${{inputs.BUILT_EARTHLY_PATH}} github.com/EarthBuild/hello-world+hello & \
pids[${i}]=$!
${{inputs.SUDO}} ${{inputs.BUILT_EARTHLY_PATH}} --no-output github.com/EarthBuild/hello-world+hello & \
pids[i]=$!
done && \
for pid in ${pids[*]}; do
wait $pid
for pid in "${pids[@]}"; do
wait "$pid"
done
- name: Execute interactive debugger test
run: ./scripts/tests/interactive-debugger/test-interactive.py --earthly ${{inputs.BUILT_EARTHLY_PATH}} --timeout 180
Expand Down
16 changes: 11 additions & 5 deletions not-a-unit-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ touch /var/lib/shared/vfs-images/images.lock
mkdir -p /var/lib/shared/vfs-layers
touch /var/lib/shared/vfs-layers/layers.lock

# The single-quoted sed replacement is an intentional literal env-var token,
# not a value to expand at this point.
# shellcheck disable=SC2016
sed -i 's/\/var\/lib\/containers\/storage/$EARTHLY_DOCKERD_DATA_ROOT/g' /etc/containers/storage.conf

if [ -n "$DOCKERHUB_MIRROR" ]; then
Expand Down Expand Up @@ -71,8 +74,11 @@ then
fi

# then run the test
if [ -n "$testname" ]
then
testarg="-run $testname"
fi
go test -timeout 20m -json $testarg $pkgname | ./testparser
# pkgname/testname come from the Earthfile env (ARG pkgname / ARG testname),
# which the linter can't see. Build the arg list with set -- so -run "$testname"
# is quoted; pkgname is left unquoted on purpose as it may expand to several
# space-separated package patterns.
set -- -timeout 20m -json
[ -n "$testname" ] && set -- "$@" -run "$testname"
# shellcheck disable=SC2086,SC2154
go test "$@" $pkgname | ./testparser
Loading