Skip to content

build: rename internal (non-release) Earthfile targets to earthbuild-*#647

Open
kmannislands wants to merge 1 commit into
mainfrom
rename-internal-earthfile-targets
Open

build: rename internal (non-release) Earthfile targets to earthbuild-*#647
kmannislands wants to merge 1 commit into
mainfrom
rename-internal-earthfile-targets

Conversation

@kmannislands

Copy link
Copy Markdown

What

Renames internal helper/test Earthfile targets (definitions + all BUILD/FROM references + the CONTRIBUTING.md mention):

Old New
+earthly-script-no-stdout +earthbuild-script-no-stdout
+earthly-integration-test-base +earthbuild-integration-test-base
+build-earthly-test +build-earthbuild-test
+test-earthly-mirror-was-setup +test-earthbuild-mirror-was-setup
+test-works-without-earthly-server +test-works-without-earthbuild-server

Scope / safety

Internal build/test targets only. Deliberately excludes the released-artifact / entry-point targets (+earthly, +earthly-docker, +earthly-linux-amd64, +earthly-all, ...) which map to the published binary and image names and are referenced by release tooling.

Verification

  • Changed Earthfiles parse via earthly debug ast; every definition and its BUILD/FROM references remain consistent (verified no dangling refs).
  • Reduces the tracked earthly line count by 10.

🤖 Generated with Claude Code

Renames internal helper/test targets (definitions plus all BUILD/FROM
references and the CONTRIBUTING.md mention):

  +earthly-script-no-stdout          -> +earthbuild-script-no-stdout
  +earthly-integration-test-base     -> +earthbuild-integration-test-base
  +build-earthly-test                -> +build-earthbuild-test
  +test-earthly-mirror-was-setup     -> +test-earthbuild-mirror-was-setup
  +test-works-without-earthly-server -> +test-works-without-earthbuild-server

These are internal build/test targets only. Deliberately excludes the
released-artifact / entry-point targets (+earthly, +earthly-docker,
+earthly-linux-amd64, +earthly-all, etc.) which map to the published
binary and image names.

Changed Earthfiles parse via `earthly debug ast`; all definitions and
their references remain consistent. Reduces "earthly" line count by 10.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kmannislands kmannislands requested a review from a team as a code owner July 3, 2026 16:47
@kmannislands kmannislands added the ai-assisted Authored with AI assistance label Jul 3, 2026
@kmannislands kmannislands requested review from janishorsts and removed request for a team July 3, 2026 16:47
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🎉 Are we earthbuild yet?

Great progress! You've reduced "earthly" occurrences by 10 (0.18%)

📈 Overall Progress

Branch Total Count
main 5408
This PR 5398
Difference -10 (0.18%)

📁 Changes by file type:

File Type Change
Go files (.go) ➖ No change
Documentation (.md) ➖ No change
Earthfiles ✅ -10

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames several targets and references from "earthly" to "earthbuild" across the codebase, including in CONTRIBUTING.md, Earthfile, and various test configurations. Feedback on the changes highlights that the renamed test-earthbuild-mirror-was-setup target is currently dead code because it is not referenced by any active test groups, and recommends adding it to the test suite so that it is executed.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/Earthfile
RUN cat output | perl -pe 'BEGIN {$status=1} END {exit $status} $status=0 if /\+run2 \| 2\n/;'

test-earthly-mirror-was-setup:
test-earthbuild-mirror-was-setup:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test target test-earthbuild-mirror-was-setup (formerly test-earthly-mirror-was-setup) is defined here but is not referenced by any of the test groups (such as ga-no-qemu-group*) or any other target in the repository. This means this integration test is currently dead code and is never executed during the test suite run.\n\nPlease consider adding it to one of the active test groups (for example, ga-no-qemu-group12 or another appropriate group) so that it is run as part of the integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Authored with AI assistance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants