Run pride-ppp test suite in CI - #30
Merged
Merged
Conversation
The CI test job only ran pytest for gnss-product-management and gpm-cli, so the 35 tests under packages/pride-ppp/tests/ (including test_rinex_time_range.py from #24) were never executed. Add a pytest step for them and include the directory in the root testpaths so a bare pytest run picks them up too. No "not integration" filter is needed: none of the pride-ppp tests hit the network or carry the integration marker. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI test job only ran pytest for
gnss-product-managementandgpm-cli, so the 35 tests underpackages/pride-ppp/tests/(includingtest_rinex_time_range.pyfrom #24) were never executed and regressions in the pride-ppp package went undetected.uv run pytest packages/pride-ppp/tests/ -qto the CI test jobpackages/pride-ppp/teststo the roottestpathsso a barepytestrun also covers the suiteNo
-m "not integration"filter is needed: none of the pride-ppp tests hit the network or carry theintegrationmarker.gpm-specswas also checked — it has no test directory, so there is nothing to add for it.Test plan
Ran the full CI sequence locally with the same
uv sync --group dev --group testinstall the workflow uses (verified it installspride_ppp):ruff check/ruff format --check: clean🤖 Generated with Claude Code