integrates rinex v4.02 useage - #20
Merged
Merged
Conversation
✅ Deploy Preview for earthscope-sfg-workflows ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates EarthScope SFG workflows to accommodate RINEX v4.02 (notably the v3/v4 “long name” .rnx outputs) across generation, detection, compression, and downstream parsing.
Changes:
- Update SV3/QC pipelines to treat
tdb2rnxoutputs as*.rnxand clean up stale outputs accordingly. - Extend file-type detection and plotting timestamp parsing to recognize RINEX v3/v4 long-name formats.
- Adjust sync-time Hatanaka compression to produce
.crx.gzfrom.rnxinputs; pinearthscope-sfg-toolstorev=0.1.2inpixi.lock.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/earthscope_sfg_workflows/utils/model_update.py | Updates invalid-key error formatting for Pydantic models (currently introduces an instance/class name bug). |
| src/earthscope_sfg_workflows/services/sync_service.py | Updates RINEX compression naming to handle .rnx → .crx.gz for v3/v4 long names. |
| src/earthscope_sfg_workflows/pipelines/sv3_pipeline.py | Switches RINEX discovery/cleanup from legacy *.??o to *.rnx; adds stricter filtering for processable local RINEX entries. |
| src/earthscope_sfg_workflows/pipelines/qc_pipeline.py | Mirrors the SV3 pipeline’s switch to *.rnx discovery/cleanup for QC RINEX generation. |
| src/earthscope_sfg_workflows/pipelines/plotting.py | Parses both RINEX v2 and v3/v4 epoch record formats when computing the last timestamp. |
| src/earthscope_sfg_workflows/data_mgmt/core.py | Extends FileTypeDetector patterns to classify RINEX v3/v4 long-name .rnx obs/nav files. |
| pixi.lock | Pins earthscope-sfg-tools Git dependency to rev=0.1.2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mikegottlieb84
approved these changes
Jul 21, 2026
mikegottlieb84
left a comment
mikegottlieb84
left a comment
Contributor
There was a problem hiding this comment.
still need to fix the AssetKind.RINEX3->4
Resolves conflicts with the version-aware RINEX handling merged in #21: - pipelines: keep this branch's broader stale-file cleanup (*.rnx plus legacy *.??o short names) on top of main's long-name output handling - sv3_pipeline.run_pride: combine main's RINEX_KINDS filter with this branch's guard against missing/0-byte RINEX files - tests: adopt main's long-format tdb2rnx filenames and the .25o fixture; drop the now-unused trimmed NCC12510.rnx fixture Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Same format-check failure as on ftd-fix-general-audit (pre-existing line-wrap in shotdata_gnss_refinement.py). Also refreshes pixi.lock, which was stale relative to pyproject.toml's already-pinned earthscope-sfg-tools rev. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
clone-garpos was cloning unpinned upstream master and git-pulling on re-runs, while compile-garpos hardcodes the bin/garpos_v102/f90lib path from v1.0.2 - upstream master has since moved to a v120 layout, breaking `pixi run setup`/test-garpos on every fresh clone (matches AUDIT_FRICTION_LOG.md §2.2). Verified clean from a fresh .pixi/garpos. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- Remove unused imports (F401) flagged by ruff --fix - sv3_pipeline: move third-party/local imports above the monkey-patch code so all imports sit at the top of the module (E402); no module-level captures of the patched methods exist, so ordering is behavior-neutral - session: move the _Site alias below the import block (E402) and add Survey plus the TDB* array types to the TYPE_CHECKING imports used by quoted annotations (F821) - core/ports/adapters.memory: import SFGScope and Path used in annotations (F821) - tests: drop unused TDBIMUPositionArray from the dependency probe Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR accomodates the upgrade to rinex version 4.02.