gui: Migrate Thorchain Savers and Yield endpoints off NineRealms#5996
Merged
gui: Migrate Thorchain Savers and Yield endpoints off NineRealms#5996
Conversation
peachbits
approved these changes
Apr 17, 2026
d3dcc88 to
abe5e83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
Requirements
If you have made any visual changes to the GUI. Make sure you have:
No visual changes — URL-only migration.
Description
Asana task
Migrates the Thorchain Savers and Thorchain Yield stake plugins off
*.ninerealms.com. Those hosts are being retired on 2026-04-20 (already returning 301). Without this change Thorchain Savers + Yield stop loading positions, quoting stakes, and fetching inbound addresses.Migration commit (
Migrate Thorchain Savers and Yield endpoints off NineRealms):src/plugins/stake-plugins/thorchainSavers/tcSaversPlugin.tsxMIDGARD_SERVERS_DEFAULT[0]:midgard.ninerealms.com→gateway.liquify.com/chain/thorchain_midgardTHORNODE_SERVERS_DEFAULT[0]:thornode.ninerealms.com→gateway.liquify.com/chain/thorchain_apisrc/plugins/stake-plugins/thorchainSavers/tcSaversPluginSegwit.tsx— same two line changes (file is a near-duplicate of the non-Segwit variant)src/plugins/stake-plugins/generic/pluginInfo/thorchainYield.tsthornodeServers[0]:thornode.ninerealms.com→gateway.liquify.com/chain/thorchain_apiLint-fix commit (
Fix lint warnings in tcSaversPlugin): committing the twotcSavers*files removes them from the ESLint warning-suppression list. That promotes 4 rule findings to errors. Fixes in this commit:: voidreturn type toupdatePolicyApys(both files).catch(e => …)as.catch((e: unknown) => …)and guardede.messageaccess (both files)Kept intact (intentional):
ninerealmsClientIdinit option +x-client-idheader — Liquify accepts it without issue.midgard.thorchain.info— already off NineRealms.no-deprecatedwarnings (parentNetworkFee,networkFee,getReceiveAddress) — not in the suppressed-rule set so they stay as warnings; addressing them is architectural and out of scope for a URL migration.Sibling PRs handle the actual swap plugin (edge-exchange-plugins) and the RUNE chain plugin (edge-currency-accountbased).
Asana parent: https://app.asana.com/1/9976422036640/project/1213843652804305/task/1214109247963126
Testing
Curl-verified new endpoints with existing
ninerealmsClientId:gateway.liquify.com/chain/thorchain_api/thorchain/network→ 200 OKgateway.liquify.com/chain/thorchain_midgard/v2/health→ 200 OKReviewer should confirm on device: open Thorchain Savers (APY loads, positions show), open Thorchain Yield (TCY position loads / stake quote resolves).
Note
Medium Risk
Switches Thorchain Savers and Yield plugins to new Midgard/Thornode base URLs, which could impact staking position loading/quoting if the gateway behavior differs or has downtime. Remaining changes are lint/type-safety fixes with low functional risk.
Overview
Updates Thorchain Savers (including Segwit variant) and Thorchain Yield stake plugins to stop using
*.ninerealms.comand instead query Thorchain Midgard/Thornode viahttps://gateway.liquify.com/chain/*.As part of committing these files, removes them from the ESLint ignore list and fixes newly-enforced lint issues by adding explicit
voidreturn types and saferunknownerror handling in a.catchpath. Also records the migration inCHANGELOG.md.Reviewed by Cursor Bugbot for commit abe5e83. Bugbot is set up for automated code reviews on this repo. Configure here.