Skip to content

gui: Migrate Thorchain Savers and Yield endpoints off NineRealms#5996

Merged
j0ntz merged 2 commits intodevelopfrom
jon/thorchain-migrate-ninerealms
Apr 18, 2026
Merged

gui: Migrate Thorchain Savers and Yield endpoints off NineRealms#5996
j0ntz merged 2 commits intodevelopfrom
jon/thorchain-migrate-ninerealms

Conversation

@j0ntz
Copy link
Copy Markdown
Contributor

@j0ntz j0ntz commented Apr 17, 2026

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

No visual changes — URL-only migration.

Description

Asana task

Migrates the Thorchain Savers and Thorchain Yield stake plugins off *.ninerealms.com. Those hosts are being retired on 2026-04-20 (already returning 301). Without this change Thorchain Savers + Yield stop loading positions, quoting stakes, and fetching inbound addresses.

Migration commit (Migrate Thorchain Savers and Yield endpoints off NineRealms):

  • src/plugins/stake-plugins/thorchainSavers/tcSaversPlugin.tsx
    • MIDGARD_SERVERS_DEFAULT[0]: midgard.ninerealms.comgateway.liquify.com/chain/thorchain_midgard
    • THORNODE_SERVERS_DEFAULT[0]: thornode.ninerealms.comgateway.liquify.com/chain/thorchain_api
  • src/plugins/stake-plugins/thorchainSavers/tcSaversPluginSegwit.tsx — same two line changes (file is a near-duplicate of the non-Segwit variant)
  • src/plugins/stake-plugins/generic/pluginInfo/thorchainYield.ts
    • thornodeServers[0]: thornode.ninerealms.comgateway.liquify.com/chain/thorchain_api

Lint-fix commit (Fix lint warnings in tcSaversPlugin): committing the two tcSavers* files removes them from the ESLint warning-suppression list. That promotes 4 rule findings to errors. Fixes in this commit:

  • Added : void return type to updatePolicyApys (both files)
  • Typed .catch(e => …) as .catch((e: unknown) => …) and guarded e.message access (both files)

Kept intact (intentional):

  • ninerealmsClientId init option + x-client-id header — Liquify accepts it without issue.
  • Secondary fallback midgard.thorchain.info — already off NineRealms.
  • 21 remaining no-deprecated warnings (parentNetworkFee, networkFee, getReceiveAddress) — not in the suppressed-rule set so they stay as warnings; addressing them is architectural and out of scope for a URL migration.

Sibling PRs handle the actual swap plugin (edge-exchange-plugins) and the RUNE chain plugin (edge-currency-accountbased).

Asana parent: https://app.asana.com/1/9976422036640/project/1213843652804305/task/1214109247963126

Testing

Curl-verified new endpoints with existing ninerealmsClientId:

  • gateway.liquify.com/chain/thorchain_api/thorchain/network → 200 OK
  • gateway.liquify.com/chain/thorchain_midgard/v2/health → 200 OK

Reviewer should confirm on device: open Thorchain Savers (APY loads, positions show), open Thorchain Yield (TCY position loads / stake quote resolves).


Note

Medium Risk
Switches Thorchain Savers and Yield plugins to new Midgard/Thornode base URLs, which could impact staking position loading/quoting if the gateway behavior differs or has downtime. Remaining changes are lint/type-safety fixes with low functional risk.

Overview
Updates Thorchain Savers (including Segwit variant) and Thorchain Yield stake plugins to stop using *.ninerealms.com and instead query Thorchain Midgard/Thornode via https://gateway.liquify.com/chain/*.

As part of committing these files, removes them from the ESLint ignore list and fixes newly-enforced lint issues by adding explicit void return types and safer unknown error handling in a .catch path. Also records the migration in CHANGELOG.md.

Reviewed by Cursor Bugbot for commit abe5e83. Bugbot is set up for automated code reviews on this repo. Configure here.

@j0ntz j0ntz force-pushed the jon/thorchain-migrate-ninerealms branch from d3dcc88 to abe5e83 Compare April 18, 2026 02:01
@j0ntz j0ntz merged commit b0ceecd into develop Apr 18, 2026
3 of 4 checks passed
@j0ntz j0ntz deleted the jon/thorchain-migrate-ninerealms branch April 18, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants