-
Notifications
You must be signed in to change notification settings - Fork 10
Improve title functions of the wdt module
#565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR, especially for including tests. Both the robust functions and the tests look good to me, although there seems to be an issue with the expected results. I realized one minor issue with the unit tests. I got 12 failures when running the wdt-tests and they all are related to the language. Since expected output is hard coded and the wdt functions don't take language as an argument and just guess it through PS: There is one unrelated error (not failure) in the biblio tests for which I'll add a new issue. |
by checking for empty `$ab` at various places within the `title` function.
and not in the diaries facs collection
to not fail for empty sequence as input
to accept a sequence of input items
to accept a sequence of input items
for the `title` functions and make sure to use only documents that are available from the test data
with latest changes to the `title` function
from `$wdt:functions`
e4ec835 to
e6b51ad
Compare
which will currently fail for an input sequence of items
also added/fixed: