Skip to content

Conversation

@peterstadler
Copy link
Member

which will currently fail for an input sequence of items

also added/fixed:

  • add unit tests for these functions
  • exclude non-ab-root diaries from backlinks

@peterstadler peterstadler linked an issue Dec 8, 2025 that may be closed by this pull request
@peterstadler peterstadler added this to the Release 4.14 milestone Dec 8, 2025
@SteffenAstheimer SteffenAstheimer self-requested a review December 10, 2025 13:20
@SteffenAstheimer
Copy link
Contributor

Thanks for the PR, especially for including tests. Both the robust functions and the tests look good to me, although there seems to be an issue with the expected results.

I realized one minor issue with the unit tests. I got 12 failures when running the wdt-tests and they all are related to the language. Since expected output is hard coded and the wdt functions don't take language as an argument and just guess it through config:guess-language(), the tests throw failures if the browser is set to a different language than German.
I guess there is no real fix to this other than to keep it in mind when testing.
I saw a similar problem with the quotation marks in the biblio tests, even though each bibl function takes the language as an argument. But some components of the citation are transformed with xsl, which again guesses the language through config:guess-language().
So in other words, I guess there is no easy fix to this problem and unit tests just have to be run on a browser which defaults to german language.

PS: There is one unrelated error (not failure) in the biblio tests for which I'll add a new issue.

by checking for empty `$ab` at various places within the `title` function.
and not in the diaries facs collection
to not fail for empty sequence as input
to accept a sequence of input items
to accept a sequence of input items
for the `title` functions and make sure to use only documents that are available from the test data
with latest changes to the `title` function
@SteffenAstheimer SteffenAstheimer merged commit 1caf511 into develop Dec 17, 2025
2 of 3 checks passed
@SteffenAstheimer SteffenAstheimer deleted the improve-wdt-diaries branch December 17, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backlinks for "Detmold" not working

3 participants