Enforce default options

[Eeems]

Summary by CodeRabbit

• Tests

  • Expanded coverage for default VELBUILD option presets and verified that explicitly enabling an option properly overrides the corresponding default.
  • Updated VELBUILD test fixtures to remove hard-coded negated options directives while keeping packaging logic unchanged.

• Improvements

  • Adjusted VELBUILD option handling so defaults are applied consistently and conflicts are resolved in favour of explicitly selected (non-negated) options.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 85871ab6-b275-4931-9c36-e784c99c9c38

📥 Commits

Reviewing files that changed from the base of the PR and between da973a3 and e856bc7.

📒 Files selected for processing (1)

• vbuild/velbuild.py

🚧 Files skipped from review as they are similar to previous changes (1)

• vbuild/velbuild.py

---

📝 Walkthrough

Walkthrough

Adds a VELBUILD.options getter, renders options= explicitly in APKBUILD text, and updates tests plus fixtures to reflect the new default option handling.

Changes

VELBUILD options property and test coverage

Layer / File(s)	Summary
VELBUILD.options getter and APKBUILD rendering vbuild/velbuild.py, test.py	Removes the old !fhs insertion path, skips options during main variable emission, renders options= explicitly, and defines VELBUILD.options to merge defaults with existing options and normalise conflicts. Adds test assertions for the default negated options and toggling semantics.
Remove explicit options from fixtures tests/basedir/VELBUILD, tests/basic/VELBUILD, tests/checksums/VELBUILD, tests/image/VELBUILD, tests/rmstream/VELBUILD, tests/subpackages/VELBUILD	Deletes explicit options="..." lines from the VELBUILD fixtures while leaving the rest of each package definition unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Eeems/vbuild#28: Both changes touch VELBUILD options handling and APKBUILD generation around !fhs.

Poem

🐰 I hopped through defaults with a twitchy nose,
New options now bloom in tidy rows.
!check and friends take their place,
Fixtures shed clutter with graceful pace,
And APKBUILD shines in sorted prose.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: enforcing default VELBUILD options and related toggling semantics.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}