Conversation
Flags directly adjacent Effect.map + Effect.mapError pairs (either order, pipe/pipeable and nested data-first shapes), suggesting a single Effect.mapBoth. Closes Effect-TS#628
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
mapMapErrorToMapBothdiagnostic (TS377132, groupstyle, v3+v4) for issue #628.Transforming both channels with two adjacent combinators —
Effect.map+Effect.mapErrorin either order — is exactly whatEffect.mapBoth({ onSuccess, onFailure })does in one step. The rule matches direct adjacency in pipe/pipeable chains (via checker symbol resolution, mirroringeffectMapFlatten) plus the nested data-first shapesmap(mapError(eff, g), f)andmapError(map(eff, f), g). Since the channels are independent, the rewrite is always behavior-preserving. Non-adjacent pairs stay silent.Closes #628.
Verification
go test ./internal/rules: pass (incl. TestRuleDocs/TestMetadataJSON/TestReadmeTable)go test ./internal/effecttest(full package): pass — 5 diagnostics on v4 BAD cases, no collateral on existing fixturespnpm lint: clean