Skip to content
This repository was archived by the owner on Nov 26, 2022. It is now read-only.

fix typos#204

Open
billzhong wants to merge 2 commits intoEhco1996:masterfrom
billzhong:master
Open

fix typos#204
billzhong wants to merge 2 commits intoEhco1996:masterfrom
billzhong:master

Conversation

@billzhong
Copy link
Copy Markdown

No description provided.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Aug 11, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 3.48 ⭐ 3.48 ⭐ 0.00
Method Length 31.70 ⭐ 31.70 ⭐ 0.00
Working memory 6.84 🙂 6.84 🙂 0.00
Quality 78.96% 78.96% 0.00%
Other metrics Before After Change
Lines 337 337 0
Changed files Quality Before Quality After Quality Change
shadowsocks/ciphers.py 84.10% ⭐ 84.10% ⭐ 0.00%
shadowsocks/ratelimit.py 88.87% ⭐ 88.87% ⭐ 0.00%
shadowsocks/mdb/models.py 66.18% 🙂 66.18% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
shadowsocks/mdb/models.py User.create_or_update_by_user_data_list 10 🙂 169 😞 16 ⛔ 42.32% 😞 Try splitting into smaller methods. Extract out complex expressions
shadowsocks/ciphers.py BaseAEADCipher.decrypt 14 🙂 160 😞 7 🙂 55.28% 🙂 Try splitting into smaller methods
shadowsocks/mdb/models.py User.find_access_user 7 ⭐ 111 🙂 11 😞 58.74% 🙂 Extract out complex expressions
shadowsocks/mdb/models.py User.record_traffic 0 ⭐ 36 ⭐ 10 😞 78.76% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant