Open
Conversation
| throw new Exception("Используйте допустимые значения пола животного - самец или самка"); | ||
| } | ||
| } | ||
| public Lion(Feline feline) { |
There was a problem hiding this comment.
Это нужно исправить.
изоляцию Lion от Feline нужно было делать через инъекцию зависимостей. То есть в класс Lion должен попадать уже созданный экземпляр класса Feline.
В классе должен быть только один конструктор public Lion(String sex, Feline feline).
| assertEquals(expectedMane, actualMane); | ||
| } | ||
| @Test (expected = Exception.class) | ||
| public void getManeTestException () throws Exception { |
There was a problem hiding this comment.
Это нужно доработать:
этот тест не зависит от параметризации -- его не нужно запускать несколько раз, его лучше вынести в класс LionTest
Owner
Author
There was a problem hiding this comment.
исправлено, тест добавлен в LionTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
первая проверка