Create Docker container setup for the project#51
Draft
Ryu1845 wants to merge 4 commits intoEleutherAI:developfrom
Draft
Create Docker container setup for the project#51Ryu1845 wants to merge 4 commits intoEleutherAI:developfrom
Ryu1845 wants to merge 4 commits intoEleutherAI:developfrom
Conversation
rk1a
requested changes
Feb 5, 2023
rk1a
requested changes
Feb 7, 2023
|
|
||
| WORKDIR minetest | ||
| EXPOSE 30000 | ||
| CMD ["hacking_testing/server.sh"] |
There was a problem hiding this comment.
this got me wondering, will we need a separate Dockerfile for clients?
If this is specifically for running a server then we actually don't need to build with SDL at all.
On the other hand, I guess initially we will have server and client(s) running on the same machine, maybe even the same docker container..
So in case of a single Dockerfile it probably would make sense to not hardcode the entry point here
Author
There was a problem hiding this comment.
CMD is just a default, we could make a cli with support for the different options as an entry point maybe?
There was a problem hiding this comment.
yes, that sounds good. even simpler: optionally pass a any script that is being used as entrypoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request creates a Docker container setup for the alignment-minetest project. (solves #42)
This PR is a Work in Progress.
To do