Fix independent placement of cooldown slots sharing talent overrides - #2024
Open
andybergon wants to merge 5 commits into
Open
Fix independent placement of cooldown slots sharing talent overrides#2024andybergon wants to merge 5 commits into
andybergon wants to merge 5 commits into
Conversation
Use cooldownID claims for collided spell families while retaining ordinary talent override behavior. Preserve claims across missing siblings and protect inactive buff placements during repopulation. Validate with mocked production picker, routing and repopulation regressions and Lua syntax checks. Claude Fable 5.1 review started but hit the session limit before a verdict; in-game testing remains pending.
Address Fable review findings: require distinct source spell identities and a direct override link, migrate before picker adds, and never ghost unclassified legacy buff slots. Cover duplicate views, false base ties, two displayed Virtue icons and index-based ordering.
Keep each saved slot assignment while temporarily hiding the overridden base when its separately claimed native replacement is present. Refresh suppression with live pool membership and preserve clean metadata through combat. Validate using supplied Beacon metadata and mocked production routing. Fable 5.1 reviewed the implementation and follow-up; final low-priority cache retry and coverage fixes are locally verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix cooldown slots that share a talent override moving together between bars. Beacon of Virtue can stay in Cooldowns while Beacon of Light stays in Utility. When both slots display Virtue, hide the overridden Light slot until talents change back, preserving its saved placement.
Use Blizzard cooldown IDs for these colliding slots, retaining spell-based behavior for ordinary overrides. Cooldown claims also retain cooldown settings and preview borders instead of being treated as hosted buffs.
How was it tested?
Screenshots
Before: Virtue appears in both Cooldowns and Utility.
After: Virtue remains in Cooldowns without a Utility duplicate.
After switching talents back: Light and Faith remain in Utility.
Checklist