Unit Frames: show frames while health is missing - #2044
Open
dfrisone wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an opt-in Show When Health Missing toggle to the Visibility cog for Player, Target, and Focus frames. With Mouseover selected, an injured unit stays visible without hovering; reaching full health restores the existing visibility rules. Never Show remains authoritative.
Uses a health curve to drive opacity without comparing restricted health values. Portraits and companion mini frames follow the result, while Always Show Pet remains independent. Focus changes refresh visibility, and mouseover remains active across visibility refreshes and healing to full.
This controls visual opacity; transparent frames can still accept clicks in combat. The toggle is changed out of combat.
How was it tested?
Screenshots
Before/after screenshots of the implemented toggle were not supplied and are still missing.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames — N/A for Blizzard hooks/weak tables: new state and event scripts belong to EUI-owned frames.