Skip to content

koKR: Add localization for rotation assist and chat bubbles - #2046

Open
Crazyyoungs wants to merge 2 commits into
EllesmereGaming:mainfrom
Crazyyoungs:main
Open

koKR: Add localization for rotation assist and chat bubbles#2046
Crazyyoungs wants to merge 2 commits into
EllesmereGaming:mainfrom
Crazyyoungs:main

Conversation

@Crazyyoungs

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Adds customization options for Chat Bubbles, allowing users to restyle Blizzard's chat bubbles, filter by channels (Say, Yell, NPCs, Emotes, Party, Raid), and configure styling properties (padding, font size, borders, backgrounds, and vertical offset).
  • Adds Rotation Assist Style options, providing visual cues (such as Solid Border and Pixel Glow) with customizable thickness, color, and outset for Blizzard's Assisted Combat suggestions.
  • Adds options to control behavior inside instances (automatically hiding or disabling custom styles in dungeons, raids, scenarios, or battlegrounds).

How was it tested?

  • Tested client build locally in-game.

Checklist

  • New settings default OFF (no behavior change without opt-in)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant