Fix: Chat Tabs have setting that does nothing/gets overridden - #2048
Open
svart2521 wants to merge 2 commits into
Open
Fix: Chat Tabs have setting that does nothing/gets overridden#2048svart2521 wants to merge 2 commits into
svart2521 wants to merge 2 commits into
Conversation
Bug:
Issue: right-clicking a chat tab and setting Background Color does nothing visually. EUI's chat skin hides Blizzard's entire native chat background (cf.Background:SetAlpha(0), every native region zeroed) and draws its own separate panel instead, so the native color picker has nothing left to render onto.
Fix: added an opt-in toggle under the Tabs section ("Use Tab's Background Color", off by default): when on, each tab's own background (EUI's existing tabBackgroundColor/tabBackgroundColorActive) reads that window's native color (GetChatWindowInfo, normalizing its legacy 0-255 range) instead of the shared swatches, keeping each state's own opacity. A hooksecurefunc on SetChatWindowColor re-applies it live via ApplyTabAppearance the moment the native picker is used. Temporary/whisper tabs (no real window id) always keep EUI's own color. Existing behavior unchanged when the toggle stays off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1546266301826338966
Issue: right-clicking a chat tab and setting Background Color does nothing visually. EUI's chat skin hides Blizzard's entire native chat background (cf.Background:SetAlpha(0), every native region zeroed) and draws its own separate panel instead, so the native color picker has nothing left to render onto.
Fix: added an opt-in toggle under the Tabs section ("Use Tab's Background Color", off by default): when on, each tab's own background (EUI's existing tabBackgroundColor/tabBackgroundColorActive) reads that window's native color (GetChatWindowInfo, normalizing its legacy 0-255 range) instead of the shared swatches, keeping each state's own opacity. A hooksecurefunc on SetChatWindowColor re-applies it live via ApplyTabAppearance the moment the native picker is used. Temporary/whisper tabs (no real window id) always keep EUI's own color. Existing behavior unchanged when the toggle stays off.