Fix: LUA Error on ready check - #2049
Open
svart2521 wants to merge 1 commit into
Open
Conversation
Bug: Issue: A ready check performed while already in combat (e.g. a wipe/repull mid-fight) threw ADDON_ACTION_BLOCKED for EllesmereUIBlizzardSkin trying to call ReadyCheckFrame:SetWidth(). LP.FitReadyCheck runs on every ready-check message text change via a hooksecurefunc on SetText/SetFormattedText, and unconditionally resizes ReadyCheckFrame to fit the message -- but ReadyCheckFrame is a protected frame, and SetWidth on it is combat-blocked like any other protected-frame write. Fix: FitReadyCheck now bails immediately if InCombatLockdown(), deferred once to PLAYER_REGEN_ENABLED so the popup still gets correctly fit as soon as combat clears instead of staying permanently unfit for that session. A one-shot flag collapses repeat text-hook fires while still in combat into a single retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1545611936404607056
Issue: A ready check performed while already in combat (e.g. a wipe/repull mid-fight) threw ADDON_ACTION_BLOCKED for EllesmereUIBlizzardSkin trying to call ReadyCheckFrame:SetWidth(). LP.FitReadyCheck runs on every ready-check message text change via a hooksecurefunc on SetText/SetFormattedText, and unconditionally resizes ReadyCheckFrame to fit the message -- but ReadyCheckFrame is a protected frame, and SetWidth on it is combat-blocked like any other protected-frame write.
Fix: FitReadyCheck now bails immediately if InCombatLockdown(), deferred once to PLAYER_REGEN_ENABLED so the popup still gets correctly fit as soon as combat clears instead of staying permanently unfit for that session. A one-shot flag collapses repeat text-hook fires while still in combat into a single retry.