Skip to content

Fix: Boss Frames Stack Direction inverting when Vertical Spacing is negative #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svart2521 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Boss Frames Stack Direction inverting when Vertical Spacing is negative #2050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions EllesmereUIUnitFrames/EllesmereUIUnitFrames.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9358,7 +9358,8 @@ local function ReloadFrames()
local gap = 10
-- Prefer the user-configured Vertical Spacing slider; fall back to
-- the computed barHeight+gap so an uninitialized profile is sane.
local bossSpacing = db.profile.bossSpacing or (barHeight + gap)
-- abs(): a negative slider value would flip Stack Direction's sign.
local bossSpacing = math.abs(db.profile.bossSpacing or (barHeight + gap))
local bossIdx = tonumber(unit:match("(%d+)$"))
local bossAnchored = EllesmereUI and EllesmereUI.IsUnlockAnchored and EllesmereUI.IsUnlockAnchored("boss")
local canRepoBoss1 = bossPos
Expand Down Expand Up @@ -12216,7 +12217,8 @@ function InitializeFrames()
local bossSettings = db.profile.boss or {}
local barHeight = (bossSettings.healthHeight or 34) + (bossSettings.powerHeight or 6) + (bossSettings.castbarHeight or 14)
local gap = 10
local spacing = db.profile.bossSpacing or (barHeight + gap)
-- abs(): a negative slider value would flip Stack Direction's sign.
local spacing = math.abs(db.profile.bossSpacing or (barHeight + gap))
local bossStackDir = db.profile.boss and db.profile.boss.bossStackDirection or "down"
for i = 1, 5 do
local bossUnit = "boss" .. i
Expand Down Expand Up @@ -13763,7 +13765,8 @@ local function RegisterUFUnlockElements()
db.profile.positions[k] = { point = point, relPoint = relPoint, x = x, y = y }
if EllesmereUI._unlockActive then return end
if k == "boss" then
local spacing = db.profile.bossSpacing or 60
-- abs(): a negative slider value would flip Stack Direction's sign.
local spacing = math.abs(db.profile.bossSpacing or 60)
local bossStackDir = db.profile.boss and db.profile.boss.bossStackDirection or "down"
-- boss1 to UIParent; chain 2..5 from the previous boss.
if frames.boss1 then
Expand Down Expand Up @@ -13829,7 +13832,8 @@ local function RegisterUFUnlockElements()
return x, y
end
if k == "boss" then
local spacing = db.profile.bossSpacing or 60
-- abs(): a negative slider value would flip Stack Direction's sign.
local spacing = math.abs(db.profile.bossSpacing or 60)
local bossStackDir = db.profile.boss and db.profile.boss.bossStackDirection or "down"
if frames.boss1 and not (anchored and frames.boss1:GetLeft()) then
local bx, by = SnapForFrame(frames.boss1, pos.x, pos.y)
Expand Down