New entry point for drawing overlay icons - #2057
Open
ssj17vegeta wants to merge 1 commit into
Open
Conversation
This commit integrates a new entry-point that allows plugging third-party addons like CanIMogIt (which draws a small icon representing whether items can be transmogged) with EllemereUI's bags. See https://github.com/ssj17vegeta/EllesmereUIBags_CanIMogIt to see the intended use-case for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR integrates a new entry-point that allows plugging third-party addons like CanIMogIt (which draws a small icon representing whether items can be transmogged) with EllemereUI's bags.
See the compatibility patch for its intended use-case.
Without having both CanIMogIt and its compatibility patch I made, the modification does nothing (since EUI_Bags.itemOverlayIcons == {} thus the loop gets out immediately).
How was it tested?
Latest live Midnight build as of September 11th 2026.
Basically, have a transmoggable/collectible item in your bag, CanIMogIt's transmog-status icon should appear if you have CanIMogIt and its compatibility patch installed.
Tests made : not-transmogged item bought, switched it between bank, guild bank, different bags, icon shows up fine in own bag, no LUA error, no perceivable slowdown.
Screenshots
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames