Fix: Replace with Buff not routing Resonant Energy to Halo - #2064
Open
svart2521 wants to merge 1 commit into
Open
Conversation
Bug: Issue: Resonant Energy resolves to three different spell ids depending on context (453850 the live player aura, 453845 the Cooldown Viewer's own canonical id, 453846 a third curated alt), and the "Replace with Buff" diversion only registered whichever single id the picker happened to store, so the swap lookup missed and the buff rendered as its own extra icon instead of taking Halo's slot. A related bug in the alt-lookup itself only linked a curated entry's primary id to each alt individually, not every member to every other member, so even adding the missing id would not have connected it to the others. Fix: Curated all three Resonant Energy ids together in EllesmereUI_BuffPresets.lua, and reworked the alt-lookup in EllesmereUICdmHooks.lua to link every id in one curated entry to every other id in that entry, then applied that expanded lookup to both the buff-diversion map and the cooldown-replacement-target map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1547281639153864704
Issue: Resonant Energy resolves to three different spell ids depending on context (453850 the live player aura, 453845 the Cooldown Viewer's own canonical id, 453846 a third curated alt), and the "Replace with Buff" diversion only registered whichever single id the picker happened to store, so the swap lookup missed and the buff rendered as its own extra icon instead of taking Halo's slot. A related bug in the alt-lookup itself only linked a curated entry's primary id to each alt individually, not every member to every other member, so even adding the missing id would not have connected it to the others.
Fix: Curated all three Resonant Energy ids together in EllesmereUI_BuffPresets.lua, and reworked the alt-lookup in EllesmereUICdmHooks.lua to link every id in one curated entry to every other id in that entry, then applied that expanded lookup to both the buff-diversion map and the cooldown-replacement-target map.