Fix: CDM keybind missing for macros using equip-slot shorthand (/use 13) - #2067
Open
svart2521 wants to merge 1 commit into
Open
Conversation
Bug: A macro using the equip-slot shorthand for a trinket (#showtooltip 13, /use 13) never shows its keybind on the CDM icon, while the same macro written with the item's full name (#showtooltip/#use Item Name) works. Issue: _ResolveSlotBinding's macro branch only special-cased Blizzard's "smart" single-SPELL macro resolution (subType == "spell", where GetActionInfo's id is authoritatively the spellID). It had no equivalent case for Blizzard's single-ITEM resolution (subType == "item"), even though this exact subType is already handled elsewhere in the codebase (ActionBars.lua, CdmHooks.lua's SlotSpellID) as a real, distinct return value. Without that branch, an equip-slot macro fell through entirely to the macro-name/body- scan path with no direct answer available from Blizzard itself. Fix: Added an elseif subType == "item" branch mirroring the existing spell one: register the keybind under -id (the actual itemID Blizzard already resolved), then fall through to the body scan in stable mode same as the spell case. Compiles clean (luac5.1 -p).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1540449760836853940
A macro using the equip-slot shorthand for a trinket (#showtooltip 13, /use 13) never shows its keybind on the CDM icon, while the same macro written with the item's full name (#showtooltip/#use Item Name) works.
Issue:
_ResolveSlotBinding's macro branch only special-cased Blizzard's "smart" single-SPELL macro resolution (subType == "spell", where GetActionInfo's id is authoritatively the spellID). It had no equivalent case for Blizzard's single-ITEM resolution (subType == "item"), even though this exact subType is already handled elsewhere in the codebase (ActionBars.lua, CdmHooks.lua's SlotSpellID) as a real, distinct return value. Without that branch, an equip-slot macro fell through entirely to the macro-name/body- scan path with no direct answer available from Blizzard itself.
Fix:
Added an elseif subType == "item" branch mirroring the existing spell one: register the keybind under -id (the actual itemID Blizzard already resolved), then fall through to the body scan in stable mode same as the spell case.