Skip to content

Fix: enchanting off-hand weapon hides both weapon-enchant reminders #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svart2521 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: enchanting off-hand weapon hides both weapon-enchant reminders #2071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions EllesmereUIAuraBuffReminders/EllesmereUIAuraBuffReminders.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3482,9 +3482,11 @@ end
function EABR.EmitWeaponEnchantReminders(missing, co)
local hasMH, mhExpire, _, _, hasOH, ohExpire = EABR.WeaponEnchants()
for i = 1, 2 do
local slot = (i == 1) and 16 or 17
local has = (i == 1) and hasMH or hasOH
local expire = (i == 1) and mhExpire or ohExpire
local slot, has, expire
-- Plain if/else, not "cond and a or b": that idiom silently falls
-- through to b whenever a (hasMH) is false, corrupting slot 16.
if i == 1 then slot, has, expire = 16, hasMH, mhExpire
else slot, has, expire = 17, hasOH, ohExpire end
local r = EABR._resolved.we[slot]
local cat = r.cat
local shouldRemind = false
Expand Down