Skip to content

Add icons to the Bags currency dropdown - #2073

Open
andybergon wants to merge 1 commit into
EllesmereGaming:mainfrom
andybergon:t3code/show-icons-in-dropdown
Open

Add icons to the Bags currency dropdown#2073
andybergon wants to merge 1 commit into
EllesmereGaming:mainfrom
andybergon:t3code/show-icons-in-dropdown

Conversation

@andybergon

Copy link
Copy Markdown
Contributor

What does this PR do?

Show currency icons beside the names in Bags > Enabled Currencies, including retired currencies when a texture is available. Uses the dropdown's existing icon support; search, grouping, and tracking behavior stay unchanged.

How was it tested?

  • Installed the two-line change on live with a verified backup. The supplied after screenshot confirms icons render in the currency dropdown.
  • git diff --check passed. Retired currencies and missing textures were checked in code, not verified in game.

Screenshots

Before:

Currency dropdown before, with names and checkboxes only

After:

Currency dropdown after, with icons beside currency names

Checklist

  • New settings default OFF: no setting added; this visual enhancement appears whenever the dropdown is opened.
  • Zero cost while disabled: no new events, polling, or hooks; icons use the existing menu row construction.
  • Cheap while enabled: no new polling, timers, or per-frame logic.
  • No new writes onto Blizzard-owned frames.
  • Tested in-game on live via the supplied screenshot; no version gates or pre-Midnight APIs added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant