Fix Great Vault Escape handling when opened through macros or other addons - #2075
Open
andybergon wants to merge 1 commit into
Open
Fix Great Vault Escape handling when opened through macros or other addons#2075andybergon wants to merge 1 commit into
andybergon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make Escape close the Great Vault consistently when it is opened through another addon or a macro, as it already does through EllesmereUI's minimap and Data Bars shortcuts.
Currently, those EUI shortcuts register the Vault with the shared Escape handler when clicked. Opening it through another route first misses that registration. Register it once when the Vault UI is available instead, and remove the repeated registrations from the shortcuts.
How was it tested?
git diff --checkpassed.Checklist
HookScriptintegration.