Fix: CDM keybind priority favored higher-numbered action bars over Action Bar 1 - #2077
Open
svart2521 wants to merge 1 commit into
Open
Conversation
…tion Bar 1 Bug: When the same ability is bound to both Action Bar 1 and a higher bar (e.g. Action Bar 2), the Cooldown Manager shows the higher bar's keybind instead of Action Bar 1's. Issue: The keybind cache resolves ties by numeric tier, lower wins. Action Bar 1 (the main bar) was tier 10, while every dedicated multi-action-bar (bars 2-10) sat at tiers 1-9 -- so any dedicated bar always outranked Action Bar 1, opposite of the ascending "lower bar number wins" order players expect. Fix: Renumbered the tiers to ascend with bar number (Action Bar 1 = 1, Bar 2 = 2, ... Bar 10 = 10), with the form/stealth/skyriding bonus pages still ranking last since they're situational rather than an explicit per-bar placement. Macro deprioritization and the page 2-6 exclusion are unaffected. Compiles clean (luac5.1 -p).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1524027637964734485
When the same ability is bound to both Action Bar 1 and a higher bar (e.g. Action Bar 2), the Cooldown Manager shows the higher bar's keybind instead of Action Bar 1's.
Issue:
The keybind cache resolves ties by numeric tier, lower wins. Action Bar 1 (the main bar) was tier 10, while every dedicated multi-action-bar (bars 2-10) sat at tiers 1-9 -- so any dedicated bar always outranked Action Bar 1, opposite of the ascending "lower bar number wins" order players expect.
Fix:
Renumbered the tiers to ascend with bar number (Action Bar 1 = 1, Bar 2 = 2, ... Bar 10 = 10), with the form/stealth/skyriding bonus pages still ranking last since they're situational rather than an explicit per-bar placement. Macro deprioritization and the page 2-6 exclusion are unaffected.