Conversation
Bug: When a unit frame's name/target text zone is set to class-colored, the text stays at its old color when the unit's hostility flips (friendly -> hostile etc). The health bar recolors correctly at the same moment. Issue: The "text" channel in EUI_UnitFrames_Engine.lua's CHANNEL_EVENTS table (which drives PaintText, the painter that calls ApplyClassColor on name/target text zones via ns.ResolveUnitNameColor) never listed UNIT_FACTION, unlike the "health" channel. UNIT_FACTION was already treated as an always-deliver identity event (IDENTITY_EVENTS), so the engine was already built to route it to any channel that asked for it -- text just never asked. Fix: Added UNIT_FACTION to the "text" channel's event list, so name/target text repaints on the same reaction-change edge the health bar already uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1547242657347145728
When a unit frame's name/target text zone is set to class-colored, the text stays at its old color when the unit's hostility flips (friendly -> hostile etc). The health bar recolors correctly at the same moment.
Issue: The "text" channel in EUI_UnitFrames_Engine.lua's CHANNEL_EVENTS table (which drives PaintText, the painter that calls ApplyClassColor on name/target text zones via ns.ResolveUnitNameColor) never listed UNIT_FACTION, unlike the "health" channel. UNIT_FACTION was already treated as an always-deliver identity event (IDENTITY_EVENTS), so the engine was already built to route it to any channel that asked for it -- text just never asked.
Fix: Added UNIT_FACTION to the "text" channel's event list, so name/target text repaints on the same reaction-change edge the health bar already uses.