Conversation
In name-only mode, ApplyFriendlyFontOverride read the flags back off SystemFont_NamePlate / SystemFont_NamePlate_Outlined and only fell through to GetNPOutline() when they were nil. Blizzard's stock font objects always carry non-nil flags, so the configured outline was never applied: friendly player names kept Blizzard's flags while the friendly NPC overlays, which call GetNPOutline() directly, honoured the setting. Stamp GetNPOutline() on both font objects directly, and fold the flags into the file/size stamp so an outline change re-applies instead of being skipped as unchanged. Fixes EllesmereGaming#1653 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Friendly player names in Name Only mode now render with the outline configured
in EUI's font settings. Previously they always rendered without one, while the
friendly NPC overlays next to them honoured the setting.
ApplyFriendlyFontOverrideread the flags back offSystemFont_NamePlate/SystemFont_NamePlate_Outlinedand only fell through toGetNPOutline()whenthey were nil:
Blizzard's stock font objects always carry non-nil flags, so the
orneverreached the setting and the configured outline was silently dropped. The NPC
overlay path (
ShowNPCOverlay) callsGetNPOutline()directly, which is whyNPC names were fine and player names were not.
Now stamps
GetNPOutline()on both font objects directly, and folds the flagsinto the existing file/size stamp so an outline change re-applies instead of
being skipped as unchanged. Same cost profile as before: one
SetFontperobject, only when file, size or flags actually differ.
Fixes #1653
How was it tested?
Live 12.1 client, build 9.1.8, Name Only mode with Show Friendly NPC Nameplates
on as a control group, Outline Mode set to Outline.
had one.
Screenshots
Before:
After:

Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames - N/A, touches the shared font objects the same way the existing code already did🤖 Generated with Claude Code