optimize portal ticker loop and eliminate uninitialized reflection checks - #1
Open
Spagles wants to merge 1 commit into
Open
optimize portal ticker loop and eliminate uninitialized reflection checks#1Spagles wants to merge 1 commit into
Spagles wants to merge 1 commit into
Conversation
…, and eliminate dead event handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
portalCooldownFieldreading with nativePlayer#getPortalCooldown(). In the previous implementation,hasPortalCooldown()was evaluated in the ticker beforeensureReflection()had run insideacceleratePortal(), causingportalCooldownFieldto benulland returningfalseon initial entry. Utilizing the native Bukkit API resolves this uninitialized state bug, prevents cooldown bypasses, and removes per-tick reflective invocations.startPortalTicker()to evaluateplayer.getPortalCooldown() > 0before callingisInNetherPortal(player).isInNetherPortal()allocates a newLocationobject and executes two world chunk block lookups (feetandtorso). Because players retain an active 300-tick (15-second) portal cooldown after teleporting while remaining inside the portal frame, checking the primitive integer first avoids thousands of redundant heap allocations and chunk queries.getHandleMethod.invoke(player)inacceleratePortal(), checked for anullPortalProcessorinstance early, and passed the resolved NMS handle directly intoresolveMaxTime(nms). This avoids invokinggetHandlevia reflection multiple times per tick and skips max-time/config calculations when the game has not yet initialized the entity's portal process.onPlayerTeleport(PlayerTeleportEvent)handler and its unused event imports. Because the method body was a no-op comment, removing it prevents Bukkit's event bus from dispatching every server-wide teleport event (commands, ender pearls, respawns) to an empty listener.