ci(automerge): require the deploy-bot app identity - #18
Merged
Merged
Conversation
Every repo now merges as emkraan-deploy-bot, so the reusable workflow requires app-client-id and app-private-key and no caller can drift back to GITHUB_TOKEN. GITHUB_TOKEN stays for the rollup read and the workflow-file-PR retry; the App is deliberately not given workflows:write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (DRAFT: merge after Emkraan/ha-shared-workflows#15)
Makes
app-client-id/app-private-keyrequired inreusable-automerge.yml, and this repo's own caller passes them. Every fleet repo now merges asemkraan-deploy-bot, so a caller can no longer drift back toGITHUB_TOKEN.GITHUB_TOKENstays for two things: reading the check rollup (the App has no checks permission) and retrying PRs that touch.github/workflows/**. The App is deliberately not givenworkflows: write: its key is an org secret visible to every repo, so that permission would let any repo's workflow rewrite CI org-wide.Held as a draft because ha-shared-workflows'
maincaller does not pass the App yet. Its #15 is stuck in the merge queue, and requiring the input now would make that repo's sweep andworkflow_runevents fail.