fix(server): make lifecycle ACL reconciliation race-safe - #101
Open
Emran025 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the
desktop-v0.0.2tag workflow failure in the Server Windows lifecycle contract.The failure occurred during the required second
claim --owner server-desktop: the first service was already operating and could remove a transient runtime entry after the ACL traversal had enumerated it. The recursive ACL traversal treated that descendantNotFoundas a fatal error, even though the service remained healthy and the private data root itself still existed.The fix preserves the security boundary:
Validation
git diff --checknode frontend/scripts/create-release-manifests.test.mjsRelease impact
The existing
desktop-v0.0.2tag remains pointed at the already merged0.0.2source revision and its workflow failed before release creation. After this PR is approved and merged, the tag will be moved only to the verified main revision and the release workflow will be rerun.