fix(i18n): document technical setup aria identifier - #59
Merged
Conversation
added 3 commits
August 18, 2026 06:19
Classify SetupSection's dynamic aria-labelledby identifier as a documented approved exception, record its rationale in the inventory policy, and enforce that approved exceptions have policy documentation.\n\nFixes #29.
Assert catalog entries and static setup routing independently of formatter-selected quote style, removing the unrelated test failure that prevented the i18n remediation from reaching its validation gate.\n\nRefs #56.
Derive approved exceptions from stable policy constraints including source path, JSX attribute, and literal template shape rather than formatter-sensitive source coordinates.\n\nKeep generic taxonomy entries documentary-only and reject undocumented approved statuses. Refs #29.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the CI blockers currently present on
mainand therefore on unrelated pull requests. The dynamicaria-labelledbyvalue inSetupSectionis a technical DOM identifier rather than user-facing copy. This PR records it as a documented approved exception and enforces that everyapproved-exceptionin the review-status registry has matching policy metadata.It also hardens the existing setup onboarding source-level assertions so they verify the required values independently of formatter-selected quote style. This carries the narrowly scoped fix proposed in PR #56, which could not pass its own i18n gate before this remediation.
Validation
npm run i18n:check— 28,219 candidates, 0 pending reviewnpm run test— 90 passednpm run build— passedFixes #29. Refs #56.