Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
=======================================
Coverage 81.45% 81.45%
=======================================
Files 52 52
Lines 6497 6497
Branches 6497 6497
=======================================
Hits 5292 5292
Misses 949 949
Partials 256 256 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0c67673 to
f2a7fc1
Compare
The new `checkout` action (v6) causes problems with the `update-rust-toolchain`, leading to multiple authentication headers being sent to git, which then fails. Fix by not persisting credentials. Fixes #1029.
ee3283e to
6ab6f84
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes an authentication issue in the update-rust-toolchain GitHub Actions workflow that was introduced by upgrading to actions/checkout@v6. The fix adds persist-credentials: false to prevent multiple authentication headers from being sent, which was causing git operations to fail.
Key Changes:
- Added
persist-credentials: falseconfiguration to the checkout step in the update-rust-toolchain workflow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dalonsoa
left a comment
There was a problem hiding this comment.
If it works, it works :)
Description
The new
checkoutaction (v6) causes problems with theupdate-rust-toolchain, leading to multiple authentication headers being sent to git, which then fails. Fix by not persisting credentials.I hacked the workflow to make it run and confirmed that it now works and opens a PR successfully (which I then closed without merging).
Credit goes to the author of
update-rust-toolchainfor the fix: a-kenji/update-rust-toolchain#75 (comment)Fixes #1029.
Type of change
Key checklist
$ cargo test$ cargo docFurther checks