Skip to content

Fix update-rust-toolchain workflow#1037

Merged
alexdewar merged 1 commit intomainfrom
fix-update-toolchain-workflow
Dec 19, 2025
Merged

Fix update-rust-toolchain workflow#1037
alexdewar merged 1 commit intomainfrom
fix-update-toolchain-workflow

Conversation

@alexdewar
Copy link
Copy Markdown
Member

@alexdewar alexdewar commented Dec 18, 2025

Description

The new checkout action (v6) causes problems with the update-rust-toolchain, leading to multiple authentication headers being sent to git, which then fails. Fix by not persisting credentials.

I hacked the workflow to make it run and confirmed that it now works and opens a PR successfully (which I then closed without merging).

Credit goes to the author of update-rust-toolchain for the fix: a-kenji/update-rust-toolchain#75 (comment)

Fixes #1029.

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.45%. Comparing base (db2c40a) to head (6ab6f84).
⚠️ Report is 60 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   81.45%   81.45%           
=======================================
  Files          52       52           
  Lines        6497     6497           
  Branches     6497     6497           
=======================================
  Hits         5292     5292           
  Misses        949      949           
  Partials      256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexdewar alexdewar force-pushed the fix-update-toolchain-workflow branch from 0c67673 to f2a7fc1 Compare December 18, 2025 10:43
The new `checkout` action (v6) causes problems with the `update-rust-toolchain`, leading to multiple authentication headers being sent to git, which then fails.

Fix by not persisting credentials.

Fixes #1029.
@alexdewar alexdewar force-pushed the fix-update-toolchain-workflow branch from ee3283e to 6ab6f84 Compare December 18, 2025 13:50
@alexdewar alexdewar marked this pull request as ready for review December 18, 2025 13:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an authentication issue in the update-rust-toolchain GitHub Actions workflow that was introduced by upgrading to actions/checkout@v6. The fix adds persist-credentials: false to prevent multiple authentication headers from being sent, which was causing git operations to fail.

Key Changes:

  • Added persist-credentials: false configuration to the checkout step in the update-rust-toolchain workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it works :)

@alexdewar alexdewar merged commit b55c6c1 into main Dec 19, 2025
14 checks passed
@alexdewar alexdewar deleted the fix-update-toolchain-workflow branch December 19, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow failing with git permissions issue update-rust-toolchain workflow not working

4 participants