Fix pre-commit autoupdate workflow by forking one of the hooks#1163
Merged
Fix pre-commit autoupdate workflow by forking one of the hooks#1163
pre-commit autoupdate workflow by forking one of the hooks#1163Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the pre-commit configuration to use a maintained fork of cffconvert, addressing failures in the pre-commit autoupdate workflow caused by the upstream repo being unmaintained.
Changes:
- Switch
validate-cffhook source repo fromcitation-file-format/cffconverttoEnergySystemsModellingLab/cffconvert. - Update the pinned
revfrom a commit SHA to the fork’s2.1.0release tag.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 57 57
Lines 7675 7675
Branches 7675 7675
=======================================
Hits 6716 6716
Misses 657 657
Partials 302 302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tsmbland
approved these changes
Mar 3, 2026
Collaborator
tsmbland
left a comment
There was a problem hiding this comment.
Annoying, but I'm okay with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One of the hooks we are using appears to be unmaintained ([
cffconvert]) and there is unfortunately an issue that means thatpre-commit autoupdatefalls over when it hits this repo. There doesn't appear to be any way to get the GitHub Action we are using to ignore this repo either.We could just drop the hook, but I think it's useful, so instead I forked it here and made a new release: https://github.com/EnergySystemsModellingLab/cffconvert
Note that I didn't change any code; just making the release is enough to fix the problem.
We can always change back to using the upstream version if someone else takes over maintainership (though the last release was in 2021...).
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks