point current dev version at index.html#1262
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 57 57
Lines 8195 8195
Branches 8195 8195
=======================================
Hits 7355 7355
Misses 544 544
Partials 296 296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Fixes the “Current development version” link on the documentation versions page so it routes to the built docs homepage instead of a missing Markdown source file (Issue #1254).
Changes:
- Update the “Current development version” link target from
./README.mdtoindex.htmlin the versions page template.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexdewar
left a comment
There was a problem hiding this comment.
LGTM!
This works for me locally, although not sure how to test in production without merging, couple of thoughts I had along the way:
It works for me locally too. I assume it'll work in production, but there are some weird discrepancies as you point out...
- In our current docs v2.1.0 is missing, do we need to set up the python scripts (
generate_versions_docs.pyand friends) to run in our release CI or something?
When I run it locally I see v2.1.0, but you're right that it doesn't appear on our website 😞. I'm not sure what's happening. The CI is just running just build-docs::all_with_old, so it should work the same as it does locally. It gets the version numbers from git tags, but the same tags should be available to GitHub's runners, so this is really odd.
Let's see what happens when we merge and then I'll open a separate issue about this.
- Now that we are making releases, do we want
Making a releasesection to our developer guide? Like a list of steps to follow when making a release.
Good idea! I've opened an issue for this: #1164
|
PS -- I also noticed that when I run it locally, the 404 page you see for broken links is formatted correctly, in contrast to what you see on the actual website (as @tsmbland reported). Weird. |
|
Now that we've merged #1266, it seems that the docs for v2.1.0 are appearing: https://energysystemsmodellinglab.github.io/MUSE2/versions.html |
Description
This works for me locally, although not sure how to test in production without merging, couple of thoughts I had along the way:
generate_versions_docs.pyand friends) to run in our release CI or something?Making a releasesection to our developer guide? Like a list of steps to follow when making a release.Fixes #1254
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks