Skip to content

Add year field to objectives#446

Merged
tsmbland merged 3 commits intomainfrom
yearly_objectives
Mar 18, 2025
Merged

Add year field to objectives#446
tsmbland merged 3 commits intomainfrom
yearly_objectives

Conversation

@tsmbland
Copy link
Copy Markdown
Collaborator

@tsmbland tsmbland commented Mar 14, 2025

Description

This is a nice easy, self-contained change to kick off the plans described in #442

All I'm doing here is adding a year field to the existing agent_objectives table. The actual work of adding the field is tiny, I just added a year attribute to the AgentObjective struct, a year column to the csv, and I believe the process of reading in the new data is all automatic.

Most of the work here is to do with validation:

  • checking that the year is a valid milestone year
  • checking that all agents have at least one objective for each year

I've copied each objective in the table to apply to both 2020 and 2030, but long run we want a better approach (see #444)

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.50%. Comparing base (3ff209b) to head (adf2710).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/input.rs 85.71% 0 Missing and 1 partial ⚠️
src/input/agent.rs 50.00% 0 Missing and 1 partial ⚠️
src/input/agent/objective.rs 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   95.49%   95.50%   +0.01%     
==========================================
  Files          31       31              
  Lines        4479     4515      +36     
  Branches     4479     4515      +36     
==========================================
+ Hits         4277     4312      +35     
- Misses         99      100       +1     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmbland tsmbland added this to MUSE Mar 17, 2025
@tsmbland tsmbland moved this to 🏗 In progress in MUSE Mar 17, 2025
@tsmbland tsmbland self-assigned this Mar 17, 2025
@tsmbland tsmbland marked this pull request as ready for review March 17, 2025 12:52
@tsmbland tsmbland requested a review from alexdewar March 17, 2025 12:52
Copy link
Copy Markdown
Member

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've made a couple of small suggestions.

Comment thread src/input/agent/objective.rs Outdated
Comment thread src/input/agent/objective.rs Outdated
@tsmbland tsmbland enabled auto-merge March 18, 2025 09:02
@tsmbland tsmbland merged commit 4fba7be into main Mar 18, 2025
@tsmbland tsmbland deleted the yearly_objectives branch March 18, 2025 09:04
@github-project-automation github-project-automation Bot moved this from 🏗 In progress to ✅ Done in MUSE Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants