Add decision_lexico_order parameter to agent_objectives table#461
Merged
Add decision_lexico_order parameter to agent_objectives table#461
decision_lexico_order parameter to agent_objectives table#461Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
==========================================
+ Coverage 95.40% 95.47% +0.06%
==========================================
Files 31 31
Lines 4588 4658 +70
Branches 4588 4658 +70
==========================================
+ Hits 4377 4447 +70
Misses 106 106
Partials 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I wonder if there might be a better way to structure the data, such as storing the objectives within |
alexdewar
approved these changes
Mar 20, 2025
Member
alexdewar
left a comment
There was a problem hiding this comment.
LGTM!
I guess you could store the objectives inside the decision rule enum, but I'd worry that that might make the code to access them a bit convoluted. The extra safety would be nice though. Maybe let's see how we end up using them and see if it makes sense further down the line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding the
decision_lexico_orderparameter to the objectives table, and some validationSo far the validation is checking:
decision_lexico_ordermust be specified, otherwise it mustn't beThere is still more validation to do for the objectives such as ensuring weights add to 1 (see #458), so I imagine a lot of this will change when I come to tackle that
Fixes #457
Type of change
Key checklist
$ cargo test$ cargo docFurther checks