Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
- Coverage 95.13% 95.11% -0.03%
==========================================
Files 32 32
Lines 4732 4751 +19
Branches 4732 4751 +19
==========================================
+ Hits 4502 4519 +17
Misses 119 119
- Partials 111 113 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexdewar
approved these changes
Mar 20, 2025
Member
alexdewar
left a comment
There was a problem hiding this comment.
I think it would be a bit cleaner to have _read_csv_internal return the Vec, then have the caller check whether it's empty or not. This is also ok though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
read_csvwas originally intended to disallow empty csv files, but this was lost somewhere along the way.That said, there are some instances where we might want to allow empty csv files, such as
agent_search_spaceif the user doesn't want to apply any search spaces.I've created
read_csv_optionalto allow empty csv files, modifiedread_csvto disallow empty csv files, and put the shared code in_read_csv_internal.So far only
agent_search_spaceis usingread_csv_optional. There are some other empty csv files (process_flow_share_constraintsetc.) but I believe these aren't read in yetFixes #106
Type of change
Key checklist
$ cargo test$ cargo docFurther checks