Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 32 33 +1
Lines 4752 4752
Branches 4752 4752
=======================================
Hits 4520 4520
Misses 119 119
Partials 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexdewar
approved these changes
Apr 1, 2025
Member
alexdewar
left a comment
There was a problem hiding this comment.
LGTM. I think this makes more sense too -- the assets stuff ended up growing until it took over agent.rs a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simply moving the assets code from
agent.rsto a newasset.rsfile, as I think it's cleaner this wayType of change
Key checklist
$ cargo test$ cargo docFurther checks