Skip to content

Create asset.rs#469

Merged
tsmbland merged 1 commit intomainfrom
refactor_assets
Apr 1, 2025
Merged

Create asset.rs#469
tsmbland merged 1 commit intomainfrom
refactor_assets

Conversation

@tsmbland
Copy link
Copy Markdown
Collaborator

@tsmbland tsmbland commented Apr 1, 2025

Description

Simply moving the assets code from agent.rs to a new asset.rs file, as I think it's cleaner this way

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@tsmbland tsmbland marked this pull request as ready for review April 1, 2025 12:35
@tsmbland tsmbland requested a review from alexdewar April 1, 2025 12:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 98.30508% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.11%. Comparing base (076966c) to head (6eea1d8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/asset.rs 98.30% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #469   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          32       33    +1     
  Lines        4752     4752           
  Branches     4752     4752           
=======================================
  Hits         4520     4520           
  Misses        119      119           
  Partials      113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmbland tsmbland changed the title Create assets.rs Create asset.rs Apr 1, 2025
Copy link
Copy Markdown
Member

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this makes more sense too -- the assets stuff ended up growing until it took over agent.rs a bit.

@tsmbland tsmbland merged commit 8a7ccd0 into main Apr 1, 2025
7 checks passed
@tsmbland tsmbland deleted the refactor_assets branch April 1, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants