Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 95.10% 95.13% +0.02%
==========================================
Files 35 36 +1
Lines 4947 4931 -16
Branches 4947 4931 -16
==========================================
- Hits 4705 4691 -14
Misses 120 120
+ Partials 122 120 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexdewar
left a comment
There was a problem hiding this comment.
LGTM! Nice cleanup.
The IntoIDMap trait did have some more users at one point, but it doesn't make sense to keep it around if there's just the one left.
| for search_space in iter { | ||
| for search_space_raw in iter { | ||
| let search_space = | ||
| search_space.to_agent_search_space(process_ids, commodities, milestone_years)?; |
There was a problem hiding this comment.
It's actually quite common to reuse variable names like this in Rust (it's less dangerous than in e.g. Python) but this is ok too
There was a problem hiding this comment.
Cool, yeah probably not clear why I did this but was just because later on I use agent_id from search_space_raw because search_space no longer has agent_id. So I just needed to keep seach_space_raw in the namespace. (Equally could have extracted agent_id before converting search_space_raw to search_space)
Description
A few changes to tidy up handling of IDs
agent_idfromAgentSearchSpaceprocess_idfromProcessParameterIntoIDMaptrait and method as this was only used onceFixes # (issue)
Type of change
Key checklist
$ cargo test$ cargo docFurther checks