read_csv_id_file: Remove unnecessary contains_key#480
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the duplicate check when reading CSV records by removing an explicit contains_key check and instead relying on the return value of the insert operation.
- Simplifies duplicate key detection by using map.insert return value
- Removes redundant contains_key check
Comments suppressed due to low confidence (1)
src/input.rs:156
- [nitpick] The variable name 'existing' may be ambiguous regarding its purpose; consider renaming it to something more descriptive such as 'duplicateFound' to enhance clarity.
let existing = map.insert(Rc::clone(&id), record).is_some();
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
- Coverage 95.13% 95.13% -0.01%
==========================================
Files 36 36
Lines 4931 4930 -1
Branches 4931 4930 -1
==========================================
- Hits 4691 4690 -1
Misses 120 120
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tsmbland
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while reviewing your PR. It's not actually that big of a deal, but I felt the itch to fix it anyway.