Remove Key structs

[tsmbland]

Description

Removing the Key structs, and looking up the respective HashMaps with tuple keys using the appropriate ID types

Fixes # (issue)

Type of change

• Bug fix (non-breaking change to fix an issue)
• New feature (non-breaking change to add functionality)
• Refactoring (non-breaking, non-functional change to improve maintainability)
• Optimization (non-breaking change to speed up the code)
• Breaking change (whatever its nature)
• Documentation (improve or add documentation)

Key checklist

• All tests pass: $ cargo test
• The documentation builds and looks OK: $ cargo doc

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (fd22796) to head (9f38915).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   95.12%   95.03%   -0.09%     
==========================================
  Files          36       36              
  Lines        5002     4914      -88     
  Branches     5002     4914      -88     
==========================================
- Hits         4758     4670      -88     
  Misses        123      123              
  Partials      121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[alexdewar]

LGTM. I think we could probably go one step further and turn at least some of the custom structs into type aliases. It would mean that using the standard get methods etc. would be a bit more verbose, but it would reduce the amount of boilerplate code we have, which seems like a net gain.

[tsmbland]

LGTM. I think we could probably go one step further and turn at least some of the custom structs into type aliases. It would mean that using the standard get methods etc. would be a bit more verbose, but it would reduce the amount of boilerplate code we have, which seems like a net gain.

You mean like #490?