Clarify some of the terminology around energy and activity#492
Merged
Clarify some of the terminology around energy and activity#492
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 36 36
Lines 4914 4914
Branches 4914 4914
=======================================
Hits 4670 4670
Misses 123 123
Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexdewar
approved these changes
Apr 23, 2025
Member
alexdewar
left a comment
There was a problem hiding this comment.
A couple of small comments, but otherwise all good 😄
| id: "process1".into(), | ||
| description: "Description".into(), | ||
| activity_limits, | ||
| energy_limits: activity_limits, |
Member
There was a problem hiding this comment.
I guess this variable name needs changing too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pretty much everything that we're currently referring to as "activity" actually refers to an absolute/relative quantity of energy, rather than a rate of energy consumption/production. E.g. whilst the
process_availabilities.csvfile contains limits on rates of consumption/production in each timeslice, we multiply these by timeslice lengths to get limits on quantities of energy consumption/production. Therefore, a better name for the data structure isEnergyLimitsMap, rather thanActivityLimitsMap. I've changed this, and clarified a few other things.I think we should use the term "activity" sparingly and only to refer to one specific thing: the maximum PAC production over a year (i.e. the value you get when you multiply
capacitybycap2act).I think the documentation is already specific enough about this, so I haven't changed anything there.
Fixes # (issue)
Type of change
Key checklist
$ cargo test$ cargo docFurther checks