Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
==========================================
+ Coverage 94.33% 94.54% +0.20%
==========================================
Files 37 38 +1
Lines 4751 4878 +127
Branches 4751 4878 +127
==========================================
+ Hits 4482 4612 +130
+ Misses 138 128 -10
- Partials 131 138 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Converted back to draft as this needs to be updated to use |
Collaborator
Author
|
Ok ready now (once #475 is approved) |
alexdewar
approved these changes
Apr 28, 2025
Comment on lines
+181
to
+183
| let milestone_years = vec![2020, 2025]; | ||
|
|
||
| let iter = vec![create_agent_cost_limits_raw( |
Member
There was a problem hiding this comment.
Suggested change
| let milestone_years = vec![2020, 2025]; | |
| let iter = vec![create_agent_cost_limits_raw( | |
| let milestone_years = [2020, 2025]; | |
| let iter = [create_agent_cost_limits_raw( |
Member
There was a problem hiding this comment.
For iterators with one thing in you can also just use std::iter::once
Co-authored-by: alexdewar <alexdewar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Splitting cost limits out from the main agents table so they can be specified by year
Fixes #455
Type of change
Key checklist
$ cargo test$ cargo docFurther checks