Conversation
tsmbland
changed the title
same_enduse and spend_limit filters
dalonsoa
approved these changes
Mar 26, 2025
Collaborator
dalonsoa
left a comment
dalonsoa
left a comment
There was a problem hiding this comment.
This looks good. I've made a suggestion that I think might make the code simpler and more explicit, but up to you if you want to take it. Your implementation looks fine as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny fix, but the
same_enduseandspend_limitfilters were failing because they tried to filter thetechnologiesdataset by year, but it's already been filtered by year here so complains when trying to use these filters.I've fixed that bug.
Also added a check to the decorator to enforce that
technologiescannot have a year dimension. This was a bit trickier than usual as not all filters taketechnologies, so I had to get creative usinginspect. Not sure if there's a better way to do this.Had to make a few other changes to keep the tests happy
EDIT: Switched to the approach suggested by Diego below