Conversation
dalonsoa
approved these changes
Mar 18, 2025
Collaborator
dalonsoa
left a comment
There was a problem hiding this comment.
Looks good to me. Theory says that a good seed for a RNG is a large, prime number, but I don't think that's super relevant in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We sometimes find that tests randomly fail due to issues with randomly generated test data. Ideally we'd design the tests/fixtures in a way that wasn't so sensitive to this, but for now an easy solution is to set the random seed to a value that we know produces feasible test data.
(I initially tried 0 as the seed and all unit test runs failed, then switched to 123 and they all passed)
Fixes # (issue)
Type of change
Key checklist
$ python -m pytest$ python -m sphinx -b html docs docs/buildFurther checks