Skip to content

Add tutorial for splitting sector into subsectors#690

Merged
tsmbland merged 7 commits intomainfrom
subsectors_tutorial
Apr 3, 2025
Merged

Add tutorial for splitting sector into subsectors#690
tsmbland merged 7 commits intomainfrom
subsectors_tutorial

Conversation

@tsmbland
Copy link
Copy Markdown
Collaborator

@tsmbland tsmbland commented Mar 26, 2025

Added a quick tutorial to demonstrate how a sector can be split into subsectors, and the benefits of doing so.

See the tutorial here

This also nicely demonstrates some of the things that are currently going wrong:

  • the first figure should be identical/similar to the figure in this tutorial (i.e. without splitting into subsectors), but investments in the residential sector are approximately twice as high
  • in the second figure, investment decisions should only be affected for cooking technologies, but heating technologies are also affected

I have a fix for all this, but it's messy and not ready to merge yet.

Edit: rebased off #685 (work in progress fix) and the results look much more sensible now

@tsmbland tsmbland changed the base branch from main to input_structure March 26, 2025 21:56
@tsmbland tsmbland marked this pull request as ready for review March 27, 2025 12:07
@tsmbland tsmbland requested a review from martinstringer March 27, 2025 12:39
Base automatically changed from input_structure to main March 27, 2025 12:43
@tsmbland tsmbland force-pushed the subsectors_tutorial branch 2 times, most recently from ab71ca6 to a524a34 Compare March 27, 2025 15:21
@tsmbland tsmbland changed the base branch from main to subsector_demand March 28, 2025 13:28
@tsmbland tsmbland mentioned this pull request Mar 28, 2025
8 tasks
@tsmbland tsmbland moved this to 👀 In review in MUSE Mar 28, 2025
@tsmbland tsmbland requested a review from dalonsoa March 28, 2025 15:29
Copy link
Copy Markdown
Contributor

@martinstringer martinstringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should eventually contain an explanation of how "Quantity" can change for the two service demands once split into subsectors. This is an important feature that it can otherwise take new users some time to realise on their own. But it probably makes sense to merge this version for now and add that additional enhancement later.

I would also vote that at some point, in all the examples, we replace the filenames like ExistingCapacityHeat.csv with the equivalent in lowercase with underscore, like existing_capacity_heat.csv. This is for exact correspondence with the settings file convention which helps new users keep up with what's going on and is useful if automating input file creation. But I appreciate these reasons are not strong enough to justify making that effort right now.

Copy link
Copy Markdown
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice and super clear tutorial.

I'd add in the final part, after saying that the electric stove is ditched, that the demand for gas has increased, not surprisingly, which might have an impact into the carbon production. Not relevant for the purpose of the tutorial itself, but I think it is good to highlight how the different things and decisions are interrelated.

Base automatically changed from subsector_demand to main April 3, 2025 12:30
@tsmbland tsmbland changed the base branch from main to subsector_demand April 3, 2025 12:31
@tsmbland tsmbland force-pushed the subsectors_tutorial branch from be3ce28 to 8665888 Compare April 3, 2025 12:33
@tsmbland tsmbland changed the base branch from subsector_demand to main April 3, 2025 12:34
@tsmbland
Copy link
Copy Markdown
Collaborator Author

tsmbland commented Apr 3, 2025

This should eventually contain an explanation of how "Quantity" can change for the two service demands once split into subsectors. This is an important feature that it can otherwise take new users some time to realise on their own. But it probably makes sense to merge this version for now and add that additional enhancement later.

@martinstringer Yeah good point. I didn't do this here for the simple reason that it's a single-agent simulation, but I've added a note about this at the end. I think part of the confusion is that "Quantity" doesn't really tell you what this parameter actually represents. Maybe "DemandShare" would be clearer? (We're calling it "commodity_portion" in MUSE2 but that's in a slightly different context.)

@tsmbland
Copy link
Copy Markdown
Collaborator Author

tsmbland commented Apr 3, 2025

I would also vote that at some point, in all the examples, we replace the filenames like ExistingCapacityHeat.csv with the equivalent in lowercase with underscore, like existing_capacity_heat.csv. This is for exact correspondence with the settings file convention which helps new users keep up with what's going on and is useful if automating input file creation. But I appreciate these reasons are not strong enough to justify making that effort right now.

Yeah unfortunately MUSE is riddled with these types of inconsistencies. We've been much more careful about this in MUSE2

@tsmbland tsmbland merged commit c11d1a8 into main Apr 3, 2025
14 checks passed
@tsmbland tsmbland deleted the subsectors_tutorial branch April 3, 2025 13:05
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in MUSE Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants