Skip to content

Remove Fuel and EndUse columns from technodata files#715

Merged
tsmbland merged 11 commits intomainfrom
fuels_column
Jun 10, 2025
Merged

Remove Fuel and EndUse columns from technodata files#715
tsmbland merged 11 commits intomainfrom
fuels_column

Conversation

@tsmbland
Copy link
Copy Markdown
Collaborator

@tsmbland tsmbland commented Jun 2, 2025

Description

As explained in the issue, these columns are entirely redundant as this information can be determined from the CommIn and CommOut files. There were a couple of places in the code still using the information from these columns (namely the same_fuels filter and the LCOE/EAC outputs), so I've modified these to get the relevant data from the commodity flows instead (via the comm_usage field of the technologies). I've also modified the example models and documentation, and added a warning if technodata files still contain these columns (it won't break anything, but it's a good opportunity for users to simplify their input files)

Fixes #493

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass: $ python -m pytest
  • The documentation builds and looks OK: $ python -m sphinx -b html docs docs/build

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@tsmbland tsmbland changed the title Modify filter to detect fuels Remove Fuel and EndUse columns from technodata files Jun 2, 2025
@tsmbland tsmbland marked this pull request as ready for review June 10, 2025 09:30
@tsmbland tsmbland requested a review from dalonsoa June 10, 2025 09:30
Copy link
Copy Markdown
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look OK to me. The code looks marginally more complex, but it is the right move as it also avoids inconsistencies in the input files.

@tsmbland tsmbland merged commit 06e2627 into main Jun 10, 2025
14 checks passed
@github-project-automation github-project-automation Bot moved this to ✅ Done in MUSE Jun 10, 2025
@tsmbland tsmbland deleted the fuels_column branch June 10, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Fuel and EndUse fields in Technodata.csv aren't/shouldn't be required

2 participants