Remove Fuel and EndUse columns from technodata files#715
Merged
Conversation
dalonsoa
approved these changes
Jun 10, 2025
Collaborator
dalonsoa
left a comment
There was a problem hiding this comment.
The changes look OK to me. The code looks marginally more complex, but it is the right move as it also avoids inconsistencies in the input files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As explained in the issue, these columns are entirely redundant as this information can be determined from the CommIn and CommOut files. There were a couple of places in the code still using the information from these columns (namely the
same_fuelsfilter and the LCOE/EAC outputs), so I've modified these to get the relevant data from the commodity flows instead (via thecomm_usagefield of the technologies). I've also modified the example models and documentation, and added a warning if technodata files still contain these columns (it won't break anything, but it's a good opportunity for users to simplify their input files)Fixes #493
Type of change
Key checklist
$ python -m pytest$ python -m sphinx -b html docs docs/buildFurther checks