Skip to content

Remove unnecessary mypy check in CI#45

Merged
alexdewar merged 1 commit intomainfrom
remove-unnecessary-mypy-on-ci
Apr 21, 2026
Merged

Remove unnecessary mypy check in CI#45
alexdewar merged 1 commit intomainfrom
remove-unnecessary-mypy-on-ci

Conversation

@alexdewar
Copy link
Copy Markdown
Member

We don't need to invoke mypy manually in the CI run, as mypy is already run via pre-commit.ci. Remove it.

We don't need to invoke `mypy` manually in the CI run, as `mypy` is already run via pre-commit.ci. Remove it.
@alexdewar alexdewar added this to MUSE Apr 16, 2026
@alexdewar alexdewar moved this to 👀 In review in MUSE Apr 16, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the redundant manual mypy invocation from the GitHub Actions CI workflow, relying on the existing mypy hook configured in .pre-commit-config.yaml (and run via pre-commit.ci) for type checking.

Changes:

  • Deleted the “Run mypy” step from the CI workflow.
  • Kept the CI job focused on environment setup and running pytest.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexdewar alexdewar merged commit 046b89c into main Apr 21, 2026
10 checks passed
@alexdewar alexdewar deleted the remove-unnecessary-mypy-on-ci branch April 21, 2026 06:14
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in MUSE Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants