Skip to content

Disable indirect and instanced rendering on Intel(R) HD Graphics #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IThundxr wants to merge 6 commits into from
Closed

Disable indirect and instanced rendering on Intel(R) HD Graphics #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7430817
"Fix" Creators-of-Create/Create#7577
IThundxr Jun 6, 2025
76f8db7
Add fields containing driver info to Driver Enum
IThundxr Jun 10, 2025
8544de9
Remove wrapper validation
IThundxr Jun 10, 2025
3b986a9
Make a few changes
IThundxr Jul 21, 2025
d58684e
replace vendor in readVendorString
IThundxr Jul 21, 2025
a0b4b49
Improve fix
IThundxr Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,11 @@ jobs:
restore-keys: "${{ runner.os }}-gradle-"

- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4.2.0
uses: gradle/actions/setup-gradle@v4
with:
gradle-home-cache-cleanup: true
cache-read-only: ${{ !endsWith(github.ref_name, '/dev') }}

- name: Validate Gradle Wrapper Integrity
uses: gradle/wrapper-validation-action@v2

- name: Build
# Doesn't actually publish, as no secrets are passed in, just makes sure that publishing works
# Also generate the mod jars for the test job
Expand Down
2 changes: 1 addition & 1 deletion common/src/backend/java/dev/engine_room/flywheel/backend/gl/Driver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ public enum Driver {
AMD,
INTEL,
MESA,
UNKNOWN,
UNKNOWN;
}
12 changes: 10 additions & 2 deletions common/src/backend/java/dev/engine_room/flywheel/backend/gl/GlCompat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ private static int subgroupSize() {
}

private static boolean isInstancingSupported() {
if (CAPABILITIES == null) {
if (CAPABILITIES == null || isIntelHDGraphics()) {
return false;
}
if (CAPABILITIES.OpenGL33) {
Expand All @@ -150,7 +150,7 @@ private static boolean isInstancingSupported() {
}

private static boolean isIndirectSupported() {
if (CAPABILITIES == null) {
if (CAPABILITIES == null || isIntelHDGraphics()) {
return false;
}
if (CAPABILITIES.OpenGL46) {
Expand Down Expand Up @@ -215,4 +215,12 @@ void main() {}

return success;
}

// Intel HD Graphics support* instancing and indirect rendering.
// * However, in reality the support is horrible and doesn't actually work
// so whenever we encounter these, we have to fall back to flywheel:off
public static boolean isIntelHDGraphics() {
String vendor = GL20C.glGetString(GL20C.GL_VENDOR);
return vendor != null && vendor.contains("Intel(R) HD Graphics");
}
}