Skip to content

Improvements in network code. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShashankFC wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improvements in network code. #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7ac70c
Add network-related bugs for testing
Nov 24, 2025
fc5bcd2
Merge branch 'firecracker-microvm:main' into shashank/network
Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/vmm/src/devices/virtio/net/device.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ use crate::vstate::memory::{ByteValued, GuestMemoryMmap};
const FRAME_HEADER_MAX_LEN: usize = PAYLOAD_OFFSET + ETH_IPV4_FRAME_LEN;

pub(crate) const fn vnet_hdr_len() -> usize {
mem::size_of::<virtio_net_hdr_v1>()
mem::size_of::<virtio_net_hdr_v1>() + 1
}

// This returns the maximum frame header length. This includes the VNET header plus
Expand All @@ -68,22 +68,22 @@ fn frame_bytes_from_buf(buf: &[u8]) -> Result<&[u8], NetError> {
if buf.len() < vnet_hdr_len() {
Err(NetError::VnetHeaderMissing)
} else {
Ok(&buf[vnet_hdr_len()..])
Ok(&buf[(vnet_hdr_len() + 1)..])
}
}

fn frame_bytes_from_buf_mut(buf: &mut [u8]) -> Result<&mut [u8], NetError> {
if buf.len() < vnet_hdr_len() {
Err(NetError::VnetHeaderMissing)
} else {
Ok(&mut buf[vnet_hdr_len()..])
Ok(&mut buf[(vnet_hdr_len() + 1)..])
}
}

// This initializes to all 0 the VNET hdr part of a buf.
fn init_vnet_hdr(buf: &mut [u8]) {
// The buffer should be larger than vnet_hdr_len.
buf[0..vnet_hdr_len()].fill(0);
buf[0..vnet_hdr_len()].fill(1);
}

#[derive(Debug, Default, Clone, Copy)]
Expand Down